Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate CI test output into a single string #8489

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Consolidate CI test output into a single string #8489

merged 2 commits into from
Nov 6, 2024

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Sep 9, 2024 •
edited
Loading

Having the stdout and stderr in a single string makes it easier to read when analyzing test failures. Currently if there's a test failure, we output stdout and stderr separately so we can't tell which errors were logged during which test.

For example, in https://github.com/firebase/firebase-js-sdk/actions/runs/10776099172/job/29882046607, there are tons of FIREBASE FATAL ERROR's logged, but I can't tell which tests are logging these errors, or if they're even what's causing the tests to fail.

@dlarocque
Consolidate CI test output into a single string
454912f 
Having CI test process stdout and stderr in a single string makes it
easier to read when looking through failures, since you can see the test
output alongside the error messages.

Without this, any stderr output written during a test will be captured
seperately from the test output, so when we then log it after a test
failure, we can't tell which test logged which errors.
@dlarocque dlarocque requested a review from a team as a code owner September 9, 2024 15:42
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 137254e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (3670ab8)Merge (384106b)Diff
    browser18.3 kB18.4 kB+67 B (+0.4%)
    esm524.0 kB24.1 kB+69 B (+0.3%)
    main25.1 kB25.2 kB+69 B (+0.3%)
    module18.3 kB18.4 kB+67 B (+0.4%)

  • @firebase/auth

    TypeBase (3670ab8)Merge (384106b)Diff
    browser182 kB182 kB+81 B (+0.0%)
    cordova209 kB209 kB+85 B (+0.0%)
    esm5236 kB236 kB+85 B (+0.0%)
    main179 kB179 kB+71 B (+0.0%)
    module182 kB182 kB+81 B (+0.0%)
    react-native199 kB199 kB+71 B (+0.0%)

  • @firebase/auth-cordova

    TypeBase (3670ab8)Merge (384106b)Diff
    browser209 kB209 kB+85 B (+0.0%)
    module209 kB209 kB+85 B (+0.0%)

  • @firebase/auth-web-extension

    TypeBase (3670ab8)Merge (384106b)Diff
    browser137 kB137 kB+81 B (+0.1%)
    main152 kB152 kB+69 B (+0.0%)
    module137 kB137 kB+81 B (+0.1%)

  • @firebase/auth/internal

    TypeBase (3670ab8)Merge (384106b)Diff
    browser193 kB193 kB+81 B (+0.0%)
    esm5249 kB249 kB+85 B (+0.0%)
    main214 kB214 kB+73 B (+0.0%)
    module193 kB193 kB+81 B (+0.0%)

  • @firebase/data-connect

    TypeBase (3670ab8)Merge (384106b)Diff
    browser?19.8 kB? (?)
    esm5?22.5 kB? (?)
    main?24.3 kB? (?)
    module?19.8 kB? (?)

  • @firebase/firestore

    TypeBase (3670ab8)Merge (384106b)Diff
    browser381 kB381 kB-329 B (-0.1%)
    esm5366 kB366 kB+107 B (+0.0%)
    main587 kB587 kB+357 B (+0.1%)
    module381 kB381 kB-329 B (-0.1%)
    react-native382 kB381 kB-328 B (-0.1%)

  • @firebase/firestore-lite

    TypeBase (3670ab8)Merge (384106b)Diff
    browser111 kB111 kB+179 B (+0.2%)
    esm5108 kB108 kB+399 B (+0.4%)
    main153 kB153 kB+193 B (+0.1%)
    module111 kB111 kB+179 B (+0.2%)
    react-native111 kB111 kB+179 B (+0.2%)

  • @firebase/util

    TypeBase (3670ab8)Merge (384106b)Diff
    browser23.2 kB23.4 kB+131 B (+0.6%)
    esm524.9 kB25.0 kB+131 B (+0.5%)
    main30.7 kB30.9 kB+233 B (+0.8%)
    module23.2 kB23.4 kB+131 B (+0.6%)

  • bundle

    46 size changes

    TypeBase (3670ab8)Merge (384106b)Diff
    analytics (logEvent)44.5 kB44.6 kB+59 B (+0.1%)
    app-check (CustomProvider)37.4 kB37.5 kB+59 B (+0.2%)
    app-check (ReCaptchaEnterpriseProvider)39.9 kB40.0 kB+59 B (+0.1%)
    app-check (ReCaptchaV3Provider)39.9 kB40.0 kB+59 B (+0.1%)
    auth (Anonymous)76.1 kB76.3 kB+178 B (+0.2%)
    auth (EmailAndPassword)84.4 kB84.6 kB+178 B (+0.2%)
    auth (GoogleFBTwitterGitHubPopup)103 kB103 kB+177 B (+0.2%)
    auth (GooglePopup)100 kB100 kB+178 B (+0.2%)
    auth (GoogleRedirect)100 kB100 kB+178 B (+0.2%)
    auth (Phone)86.8 kB86.9 kB+178 B (+0.2%)
    database (Append to a list of data)149 kB149 kB+59 B (+0.0%)
    database (Filtering data)148 kB148 kB+59 B (+0.0%)
    database (Listen for child events)164 kB164 kB+59 B (+0.0%)
    database (Listen for value events + Detach listeners)164 kB164 kB+59 B (+0.0%)
    database (Listen for value events)164 kB164 kB+59 B (+0.0%)
    database (Read data once)164 kB164 kB+59 B (+0.0%)
    database (Save data as transactions)166 kB166 kB+59 B (+0.0%)
    database (Sort data)150 kB150 kB+59 B (+0.0%)
    database (Write data)148 kB148 kB+59 B (+0.0%)
    firestore (CSI Auto Indexing Disable and Delete)270 kB270 kB-597 B (-0.2%)
    firestore (CSI Auto Indexing Enable)270 kB270 kB-597 B (-0.2%)
    firestore (Persistence)305 kB303 kB-1.76 kB (-0.6%)
    firestore (Query Cursors)242 kB242 kB+321 B (+0.1%)
    firestore (Query)240 kB240 kB+321 B (+0.1%)
    firestore (Read data once)228 kB228 kB+321 B (+0.1%)
    firestore (Read Write w Persistence)325 kB325 kB+28 B (+0.0%)
    firestore (Realtime updates)230 kB230 kB+314 B (+0.1%)
    firestore (Transaction)207 kB207 kB+314 B (+0.2%)
    firestore (Write data)207 kB207 kB+314 B (+0.2%)
    firestore-lite (Query Cursors)91.3 kB91.5 kB+235 B (+0.3%)
    firestore-lite (Query)87.4 kB87.6 kB+235 B (+0.3%)
    firestore-lite (Read data once)62.9 kB63.1 kB+235 B (+0.4%)
    firestore-lite (Transaction)88.1 kB88.4 kB+238 B (+0.3%)
    firestore-lite (Write data)72.5 kB72.7 kB+235 B (+0.3%)
    functions (call)32.0 kB32.0 kB+59 B (+0.2%)
    messaging (send + receive)46.9 kB47.0 kB+59 B (+0.1%)
    performance (trace)51.8 kB51.8 kB+59 B (+0.1%)
    remote-config (getAndFetch)46.3 kB46.3 kB+59 B (+0.1%)
    storage (getBytes)42.1 kB42.1 kB+59 B (+0.1%)
    storage (getDownloadURL)44.1 kB44.2 kB+59 B (+0.1%)
    storage (getMetadata)43.6 kB43.7 kB+59 B (+0.1%)
    storage (list + listAll)43.0 kB43.1 kB+59 B (+0.1%)
    storage (updateMetadata)43.9 kB43.9 kB+59 B (+0.1%)
    storage (uploadBytes)48.7 kB48.8 kB+59 B (+0.1%)
    storage (uploadBytesResumable)58.7 kB58.7 kB+59 B (+0.1%)
    storage (uploadString)48.9 kB49.0 kB+59 B (+0.1%)

  • firebase

    13 size changes

    TypeBase (3670ab8)Merge (384106b)Diff
    firebase-app-compat.js31.8 kB31.8 kB+45 B (+0.1%)
    firebase-app.js103 kB103 kB+80 B (+0.1%)
    firebase-auth-compat.js139 kB139 kB+88 B (+0.1%)
    firebase-auth-cordova.js177 kB177 kB+124 B (+0.1%)
    firebase-auth-web-extension.js117 kB117 kB+128 B (+0.1%)
    firebase-auth.js151 kB151 kB+128 B (+0.1%)
    firebase-compat.js788 kB788 kB+13 B (+0.0%)
    firebase-data-connect.js?16.5 kB? (?)
    firebase-firestore-compat.js344 kB344 kB-118 B (-0.0%)
    firebase-firestore-lite.js119 kB119 kB+179 B (+0.2%)
    firebase-firestore.js440 kB440 kB-292 B (-0.1%)
    firebase-performance-standalone-compat.es2017.js93.6 kB93.7 kB+45 B (+0.0%)
    firebase-performance-standalone-compat.js70.8 kB70.8 kB+49 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5aDHaYJKyu.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2024 •
edited
Loading

Size Analysis Report 1

This report is too large (1,242,802 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mDVRQKNwbJ.html

@DellaBitta
Copy link
Contributor

I'm going to defer to @hsubox76 on this one. Perhaps there was a reason to keep them separated originally?

@dlarocque dlarocque merged commit e3e2078 into main Nov 6, 2024
35 checks passed
@dlarocque dlarocque deleted the dl/consolidate-ci-logs branch November 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlarocque @google-oss-bot @DellaBitta @hsubox76