-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add AsyncStream support for Remote Config #15352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peterfriese
wants to merge
16
commits into
main
Choose a base branch
from
peterfriese/asyncsequences/remoteconfig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+319
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
reviewed
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @peterfriese !
Leaving approval to @ncooke3 or the RC team
ncooke3
reviewed
Sep 23, 2025
ncooke3
reviewed
Sep 24, 2025
ncooke3
reviewed
Sep 24, 2025
ncooke3
approved these changes
Sep 24, 2025
FirebaseRemoteConfig/Tests/Swift/SwiftAPI/AsyncStreamTests.swift
Outdated
Show resolved
Hide resolved
paulb777
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
configUpdates
property to RemoteConfig, providing anAsyncThrowingStream
for consuming real-time config updates. This offers a modern, Swift Concurrency-native alternative to the existing closure-based listener, making it easier to integrate real-time updates into async/await workflows.Motivation
The existing
addOnConfigUpdateListener
uses a closure-based callback, which can be cumbersome in modern Swift applications that have adopted Swift Concurrency. By providing anAsyncThrowingStream
, we offer a more ergonomic and idiomatic way for developers to receive real-time updates, simplifying their code and improving readability.Implementation Details
FirebaseRemoteConfig/Swift/RemoteConfig+Async.swift
: A new file containing an extension on RemoteConfig.FirebaseRemoteConfig/Tests/Swift/SwiftAPI/AsyncStreamTests.swift
: A new test suite for the async stream functionality.Example usage
Developers can now listen for real-time updates using a simple for try await loop:
This change is purely additive and does not affect any existing APIs.