-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Exchange token tests #14984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: exchangeToken-auth
Are you sure you want to change the base?
Exchange token tests #14984
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
location: kLocation, | ||
tenantId: kTenantID | ||
) | ||
_ = app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete?
_ = app |
} | ||
let app = FirebaseApp(instanceWithName: appName, options: options) | ||
|
||
let auth = Auth(app: app) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not do let auth = Auth(app: app, tenantConfig: tenantConfig)
? Why are we setting these 2 separately? This is different from how we implemented in other client SDKs.
Description
This PR introduces unit tests for the
ExchangeTokenRequest.swift
file, which was added to support the Bring Your Own CIAM (BYO-CIAM) feature. These tests verify that the request to the regionalizedidentityplatform.googleapis.com
service for exchanging OIDC tokens is constructed correctly.Tests Added:
prod-global
case, for both production and staging (useStaging
) environments. This includes the host, the/v2beta/
API version path, project, location, tenant, and IDP config segments.unencodedHTTPRequestBody
to ensure it contains theid_token
.To ensure the reliability and correctness of the network requests made during the OIDC token exchange flow, which is critical for the BYO-CIAM functionality.
This PR only adds test code and does not affect the SDK's public API or runtime behavior.