-
Notifications
You must be signed in to change notification settings - Fork 627
remove ktx libraries #7106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
remove ktx libraries #7106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @VinayGuthal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on simplifying the project's build configuration by removing direct references to various Firebase Kotlin extension (KTX) libraries from the subprojects.cfg
file. This change streamlines the list of subprojects, potentially indicating a shift in how these KTX modules are managed or integrated within the larger project structure.
Highlights
- Configuration Cleanup: Removed numerous explicit references to Firebase Kotlin extension (KTX) libraries from the
subprojects.cfg
file. This includes KTX modules for App Check, App Distribution, Common, Config, Crashlytics, Database, Dynamic Links, Firestore, Functions, Messaging, In-App Messaging, Installations, ML Model Downloader, Performance Monitoring, and Storage.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to remove the KTX library modules from the project. While the change in subprojects.cfg
correctly removes these modules from the build configuration, it's incomplete. There are numerous lingering dependencies on the removed KTX modules (especially firebase-common-ktx
) in various build.gradle
files across the repository. These will cause build failures. I've left a detailed comment on subprojects.cfg
listing the files that need to be updated. Please address these issues to ensure the project's integrity.
Need to update the bom configuration |
This PR removes all the KTX libraries and the docs associated with them. KTX libraries were deprecated a long time ago and now we are removing these as a part of our breaking change release.