Skip to content

Security Audit & Remediation: Repository Dependencies#3191

Open
inlined wants to merge 1 commit into
firebase:mainfrom
inlined:security-audit/repository-remediation
Open

Security Audit & Remediation: Repository Dependencies#3191
inlined wants to merge 1 commit into
firebase:mainfrom
inlined:security-audit/repository-remediation

Conversation

@inlined

@inlined inlined commented Jun 23, 2026

Copy link
Copy Markdown
Member

Security Audit & Remediation: Repository Dependencies

A. Previous CVEs

B. Changes Made

  • Purged Completely Unused Dependencies: Removed farmhash-modern from production dependencies and request, request-promise, @types/request, @types/request-promise from devDependencies. Comprehensive codebase searches (src/, test/, and scripts) confirmed these packages were 100% unused anywhere in the repository (stale leftovers from past refactorings). Removing them eliminated the tough-cookie prototype pollution vulnerability without requiring any code modifications.
  • Lockfile Security Updates: Ran npm audit fix updating dev dependency lockfile resolutions for serialize-javascript and diff.

C. Remaining CVEs

  • validator, semver, ajv, js-yaml, cross-spawn (Required by @firebase/api-documenter): No non-breaking fix available upstream without major version upgrades of rushstack tools.
  • retry-request & teeny-request (Required by @google-cloud/storage / @google-cloud/firestore): Optional cloud SDK dependencies.

D. Introduced CVEs

  • None

E. Testing Strategy

  • Ran automated linter (npm run lint:src) - passing.
  • Executed unit test suite (npm run test:unit) - passing.

@wiz-9635d3485b

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities 1 Medium
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total 1 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the project's dependencies by removing farmhash-modern from the main dependencies, as well as the deprecated request and request-promise libraries along with their corresponding TypeScript type definitions (@types/request and @types/request-promise) from the development dependencies. There are no review comments to assess, and the changes appear to be a straightforward dependency cleanup.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the farmhash-modern dependency as well as the deprecated request and request-promise packages, along with their corresponding @types definitions, from package.json and package-lock.json. It also updates various transitive dependencies in the lock file. There are no review comments provided, and I have no feedback to offer.

@lahirumaramba lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants