Security Audit & Remediation: Repository Dependencies#3191
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
Code Review
This pull request cleans up the project's dependencies by removing farmhash-modern from the main dependencies, as well as the deprecated request and request-promise libraries along with their corresponding TypeScript type definitions (@types/request and @types/request-promise) from the development dependencies. There are no review comments to assess, and the changes appear to be a straightforward dependency cleanup.
There was a problem hiding this comment.
Code Review
This pull request removes the farmhash-modern dependency as well as the deprecated request and request-promise packages, along with their corresponding @types definitions, from package.json and package-lock.json. It also updates various transitive dependencies in the lock file. There are no review comments provided, and I have no feedback to offer.
Security Audit & Remediation: Repository Dependencies
A. Previous CVEs
tough-cookieviarequest&request-promise(Severity: Moderate)serialize-javascriptviamocha(Severity: High)serialize-javascriptviamocha(Severity: Moderate)B. Changes Made
farmhash-modernfrom productiondependenciesandrequest,request-promise,@types/request,@types/request-promisefromdevDependencies. Comprehensive codebase searches (src/,test/, and scripts) confirmed these packages were 100% unused anywhere in the repository (stale leftovers from past refactorings). Removing them eliminated thetough-cookieprototype pollution vulnerability without requiring any code modifications.npm audit fixupdating dev dependency lockfile resolutions forserialize-javascriptanddiff.C. Remaining CVEs
validator,semver,ajv,js-yaml,cross-spawn(Required by@firebase/api-documenter): No non-breaking fix available upstream without major version upgrades of rushstack tools.retry-request&teeny-request(Required by@google-cloud/storage/@google-cloud/firestore): Optional cloud SDK dependencies.D. Introduced CVEs
E. Testing Strategy
npm run lint:src) - passing.npm run test:unit) - passing.