ci: Stabilize SwiftUI auth UI tests#1334
Merged
russellwheatley merged 4 commits intomainfrom Apr 2, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the reliability and flexibility of E2E tests by refactoring UI interactions, increasing timeouts, and implementing a dynamic project ID lookup for the Firebase Auth emulator. Key changes include the introduction of helper functions for pasting text and navigating to MFA management, as well as updating SMS and OOB code retrieval to iterate through multiple candidate project IDs. Feedback was provided to improve the resilience of these new lookup loops, as certain errors (such as decoding failures or non-200 HTTP responses) currently terminate the search prematurely instead of continuing to the next candidate project.
e2eTest/FirebaseSwiftUIExample/FirebaseSwiftUIExampleUITests/MFAEnrolmentUITests.swift
Outdated
Show resolved
Hide resolved
e2eTest/FirebaseSwiftUIExample/FirebaseSwiftUIExampleUITests/TestUtils.swift
Outdated
Show resolved
Hide resolved
dackers86
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardened the SwiftUI UI tests by fixing password-save prompt dismissal, making MFA navigation and emulator lookups more resilient, and replacing one remaining flaky paste-menu interaction with the shared helper so the full FirebaseSwiftUIExampleUITests suite passes reliably.