STORY-1157 TASK-5939: addressed comments - added model Id and returning a singular pipelineModel #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chuks-Ajeh
changed the title
Chuks-Ajeh
changed the title
Chuks-Ajeh
changed the title
hugohills-regnosys
previously approved these changes
Mar 26, 2025
hugohills-regnosys
previously approved these changes
Mar 27, 2025
This reverts commit 377cfd7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and the issue/story number.
STORY-1157
TASK-5939
This change introduces the modelId which allows us to stop using pipelineIds to restrict test pack tests for extension models. This change also reverts new logic that returned a list of pipelineModels and instead returns a singluar pipelineModel again
DEPENDS ON:
finos/rune-common#487
Type of change
Please delete options that are not relevant.