Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/3511 setting meta #908

Merged
merged 32 commits into from
Jan 29, 2025
Merged

Conversation

davidalk
Copy link
Contributor

@davidalk davidalk commented Jan 27, 2025

This PR implements the ability to set non reference metadata using the assignment operators as described in the first example in the following issue ticket #847

Setting of reference type meta and setting using the with-meta constructor syntax is not yet implemented.

@davidalk davidalk marked this pull request as ready for review January 28, 2025 17:57
@davidalk davidalk changed the title Story/3511/with meta phase 2 Story/3511 setting meta Jan 28, 2025
@Inject
CodeGeneratorTestHelper generatorTestHelper;

//TODO:canSetMetaLocationOnFunctionBasicOutput
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

assertEquals(expected, result);
}

@Disabled //TODO: implement setting nested meta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

@davidalk davidalk merged commit 70e9fb7 into finos:main Jan 29, 2025
3 checks passed
@davidalk davidalk deleted the story/3511/with-meta-phase-2 branch January 31, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants