Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Story 3511 setting non reference metadata on function output #905

Closed
wants to merge 21 commits into from
Closed

Story 3511 setting non reference metadata on function output #905

wants to merge 21 commits into from

Conversation

davidalk
Copy link
Contributor

@davidalk davidalk commented Jan 22, 2025 •
edited
Loading

This PR implements the ability to set non reference metadata using the assignment operators as described in the first example in the following issue ticket #847

Setting of reference type meta and setting using the with-meta constructor syntax is not yet implemented.

@davidalk davidalk changed the title Story/3511/with meta Story 3511 setting non reference meta on function output Jan 27, 2025
@davidalk davidalk marked this pull request as ready for review January 27, 2025 11:06
@davidalk davidalk changed the title Story 3511 setting non reference meta on function output Story 3511 setting non reference metadata on function output Jan 27, 2025
SimonCockx
SimonCockx reviewed Jan 27, 2025
View reviewed changes
rosetta-lang/.checkstyle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is surprising.

@davidalk davidalk closed this Jan 29, 2025
@davidalk davidalk deleted the story/3511/with-meta branch January 31, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonCockx SimonCockx SimonCockx left review comments

@hugohills-regnosys hugohills-regnosys hugohills-regnosys left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidalk @hugohills-regnosys @SimonCockx