Skip to content

Conversation

magniloquency
Copy link
Contributor

@magniloquency magniloquency commented Oct 17, 2025

  • The randomly drop packets test should be more reliable now, there's an upper bound on how many consecutive packets can be dropped for each peer
  • The tests have better error messages when they fail now, also the macro was refactored to put most of the logic in a regular function as much as possible
  • A few new tests suggested by @gxuu have been added

@magniloquency magniloquency marked this pull request as ready for review October 17, 2025 04:10
inline TestResult return_failure_if_false(
bool cond, const char* msg = nullptr, const char* cond_str = nullptr, const char* file = nullptr, int line = 0)
{
if (!cond) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment that gives the most common output string (for example file=stdout). This way if we run into problem and want to find out where the output is printed from we can grep the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants