-
Notifications
You must be signed in to change notification settings - Fork 13
Reorganize source tree #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e666877
to
c4b7d62
Compare
Why are we no longer using # examples/simple_client.py
from scaler import Client
from scaler.cluster.combo import SchedulerClusterCombo I think we should keep them consistent. @sharpener6 @rafa-be . |
User should pip install opengris-scaler and run it, not just git clone and run those examples, eventually for all the CI unit tests, should build wheel, and install it then run the tests, not run the tests before making wheels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the Python changes are fine to me.
However, looking at the #include
, I'm wondering if we shouldn't add a top scaler/
directory to all C++ files. That is:
src/
| - cpp/
| - scaler/
| - ymq/
| - ...
| - object_storage/
| - ...
| - CMakeLists.txt
| - scaler/
| - __init__.py
| - ...
Thus instead of having includes like this:
#include "ymq/logging.h"
We would have something like this:
#include "scaler/ymq/logging.h"
Which matches Python's module structure.
I get it |
Agree |
7d92c85
to
2ae85cf
Compare
@e117649 Did you tried to build the wheel and install the wheel and import scaler working? |
it is not working, I'll have it fixed in 10 minutes |
b000eee
to
6ea326c
Compare
@sharpener6 yes, importing and using scaler from a built and installed wheel now works, and all the tests running against the source (not built wheel) still work I also moved |
Signed-off-by: eric <[email protected]>
Closes #335 and closes #212