make gcc version consistent across repo #312
Closed
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafa-be
reviewed
Oct 9, 2025
Comment on lines
-88
to
+89
| CMAKE_C_COMPILER = { env = "CMAKE_C_COMPILER", default = "gcc" } | ||
| CMAKE_CXX_COMPILER = { env = "CMAKE_CXX_COMPILER", default = "g++" } | ||
| CMAKE_C_COMPILER = { env = "CMAKE_C_COMPILER", default = "gcc-14" } | ||
| CMAKE_CXX_COMPILER = { env = "CMAKE_CXX_COMPILER", default = "g++-14" } |
There was a problem hiding this comment.
We actually changed the default compiler from gcc-14 back to gcc, as we do not want to force a GCC version. For example, there is no reason to force the use of GCC 14 if the system provides GCC 15.
If gcc on your system does not link to the version you expect to use, you should export CMAKE_C_COMPILER=xxx and export CMAKE_CXX_COMPILER=xxx instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.