-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: automatically increment version in package.json on new release #596
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Thanks for the PR, @divinetettey 👍 Is there anyway we can update the |
sure, let me take a look at this |
should this run before/after the release-drafter |
@divinetettey - we want the file bumps to occur before we make the NPM and GitHub releases. This is to ensure that the releases themselves include the correct |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
=======================================
Coverage 57.39% 57.39%
=======================================
Files 46 46
Lines 1582 1582
=======================================
Hits 908 908
Misses 674 674 ☔ View full report in Codecov by Sentry. |
@divinetettey, the @divinecodes will also need to authorise with EasyCLA to merge this pull request (heads up). |
yeah, my gitconfigs got messed and the commit was pushed with my personal account. I am going to squash the commit and push it with @divinetettey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy from my end. @divinetettey - have you been able to test the update_version
step?
557 auto increment version - test
Yes, getting some failures with release-drafter, taking a look |
…ersion Revert "557 auto increment version - test"
all good on my end |
This PR attempts to resolve this issue Automatically increment version in package.json on new release 📦 . The PR aims at automating the update off the version in pacakge.json