feat(proxy): expose proxy middleware utilities (#1599)#1600
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
=======================================
Coverage 85.51% 85.51%
=======================================
Files 83 83
Lines 7877 7878 +1
Branches 1312 1312
=======================================
+ Hits 6736 6737 +1
Misses 1114 1114
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @kriswest , could you please look into this PR and please approve if everything looks good? |
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Could be simpler to export * from routes, otherwise no objectsions.
| export { | ||
| getRouter, | ||
| proxyFilter, | ||
| extractRawBody, | ||
| validGitRequest, | ||
| buildUpstreamProxyAgent, | ||
| hostMatchesNoProxy, | ||
| getOrCreateProxyAgent, | ||
| } from './routes'; |
There was a problem hiding this comment.
You could probably export * from routes as you are only missing handleMessage and handleRefsErrorMessage from the full list of routes exports.
|
Hi @kriswest , I am done with changes, could you please check? |
|
Hi @jescalada , could you please review and approve PR so that this PR will be merged? |
2 participants
Description
Exposes additional proxy middleware utilities through the @finos/git-proxy/proxy package exports to enable advanced integration and custom proxy composition.
General changes:
Added proxy middleware utilities to public ./proxy exports
Exposed request filtering and validation utilities for external use
Enabled reuse of internal proxy composition logic without deep imports
Related Issue
Resolves #1599
Checklist
General
Documentation
Configuration
config.schema.json) was modified:npm run generate-config-types)npm run gen-schema-doc)Tests
npm test)npm run lintandnpm run format:check)npm run check-types)