Remove elements repositories and distributionManagement from pom.xml #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove elements `<repositories>` and `<distributionManagement>`. By default Maven searches the central repository at https://repo.maven.apache.org/maven2/. Additional repositories can be configured in the pom.xml `repositories` element. We deploy to https://oss.sonatype.org/ but the artifacts are published to Maven Central https://mvnrepository.com/artifact/org.finos/finos We should not guide users to download our artifacts from Sonatype when they are available at Maven Central where Maven by default looks for them. If user needs to access them from Sonatype, e.g. to access the snapshots, user can configure a mirror in user specific `~/.m2/settings.xml` file.
|
Hi @mikkoi , thanks for the PR! I agree with your comment regarding the download of artifacts, so I agree on the deletion of lines 78-87, though I see that your PR also removes the WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove elements
<repositories>and<distributionManagement>.By default Maven searches the central repository at https://repo.maven.apache.org/maven2/. Additional repositories can be configured in the pom.xml
repositorieselement.We deploy to https://oss.sonatype.org/ but the artifacts are published to Maven Central https://mvnrepository.com/artifact/org.finos/finos
We should not guide users to download our artifacts from Sonatype when they are available at Maven Central where Maven by default looks for them.
If user needs to access them from Sonatype, e.g. to access the snapshots, user can configure a mirror in user specific
~/.m2/settings.xmlfile.