Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CCM Mappings to common controls #651

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

abikhuil
Copy link
Contributor

@abikhuil abikhuil commented Feb 5, 2025

No description provided.

@abikhuil abikhuil requested a review from a team as a code owner February 5, 2025 17:53
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for common-cloud-controls failed. Why did it fail? →

Name Link
🔨 Latest commit 3d3f8f9
🔍 Latest deploy log https://app.netlify.com/sites/common-cloud-controls/deploys/67afc6f382261b0008de27aa

mlysaght2017
mlysaght2017 previously approved these changes Feb 6, 2025
Copy link
Contributor

@mlysaght2017 mlysaght2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @abikhuil - can you please fix the linting issues asap so that I can merge. Thanks!

@mlysaght2017 mlysaght2017 linked an issue Feb 6, 2025 that may be closed by this pull request
@mlysaght2017
Copy link
Contributor

@damienjburks - can you help us out with the netflify issue here - thanks!

@damienjburks
Copy link
Contributor

@mlysaght2017 i am not sure why it's failing.... @robmoffat is the one who has been working on this.

I would assume that it is safe to ignore it.

@robmoffat
Copy link
Member

yes it's safe to ignore - you'd have to merge with main to fix this

@mlysaght2017
Copy link
Contributor

@abikhuil - reminder on the lint fix pls

Copy link
Contributor

@eddie-knight eddie-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this hits all the linting alerts

services/common-controls.yaml Outdated Show resolved Hide resolved
services/common-controls.yaml Outdated Show resolved Hide resolved
services/common-controls.yaml Outdated Show resolved Hide resolved
services/common-controls.yaml Outdated Show resolved Hide resolved
services/common-controls.yaml Outdated Show resolved Hide resolved
services/common-controls.yaml Outdated Show resolved Hide resolved
services/common-controls.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill in Missing Control Mappings for Common Controls
5 participants