Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finos/a11y-theme-builder#903:that lists are structured correctly (ul) #929

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ShadabImran07
Copy link

Corrected the changes @aaronreed708 you have asked regarding issue 903

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
🔨 Latest commit f730167
🔍 Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/666218c1e9967e000874e116
😎 Deploy Preview https://deploy-preview-929--glistening-gecko-6b417a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@aaronreed708 aaronreed708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with the code, but it only seems to fix the "div being inside the list" issue. The list still has an accessibility issue according to Accessibility Insights because of the "role=button" that is on the list items. I found something that might help: mui/material-ui#19469 (comment). It might be worth checking out.

"@typescript-eslint/eslint-plugin": "^7.8.0",
"@typescript-eslint/parser": "^7.8.0",
"ajv": "^7.2.4",
"eslint": "^8.57.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need these changes to build? Or did you need them for linting? If just for linting, I'd move this to your linting patch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajv need for build its shows me error when i tired to build
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't commit the themes file, please. I personally usually do this when I'm creating a commit:

# check to see which files have changed
git status

# check to see that file changes are only those that I'm expecting and that I haven't left in any extraneous
# code that I commented out or test code or extraneous logging
git diff code/src/ui/src/pages/WelcomePage.tsx code/src/ui/src/components/LeftNavTabs.tsx

# add the code files individually (by just changing git diff to git add in the previous command)
# so that I know that I'm only committing code that I mean to
git add code/src/ui/src/pages/WelcomePage.tsx code/src/ui/src/components/LeftNavTabs.tsx

Doing something like git add . sometimes grabs too much stuff.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay i will take care of that

@ShadabImran07
Copy link
Author

I have no problem with the code, but it only seems to fix the "div being inside the list" issue. The list still has an accessibility issue according to Accessibility Insights because of the "role=button" that is on the list items. I found something that might help: mui/material-ui#19469 (comment). It might be worth checking out.

how you are producing this error ,i am checking through its gives me no error see this
image

@aaronreed708
Copy link
Contributor

@ShadabImran07 try this:

  1. Load a design system
  2. Select Molecules from the tabs at the top
  3. Run the Accessibility Insights

The menu items in the left nav bar under "General Desktop" (like Avatar, Buttons, Cards) seem to be buttons that have the role="button" attribute. Let me know if that doesn't show errors in Accessibility Insights. Thanks!

@ShadabImran07
Copy link
Author

ShadabImran07 commented Jun 10, 2024

@aaronreed708 ya i can see that ,I have tried only in hompage that why its not showing the error.
i have to check all the sidebar to resolve all the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants