Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Aladdin/Blackrock #1413

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Adding Aladdin/Blackrock #1413

merged 4 commits into from
Jan 14, 2025

Conversation

robmoffat
Copy link
Member

No description provided.

@robmoffat robmoffat requested a review from a team as a code owner November 5, 2024 10:54
@robmoffat robmoffat changed the title Adding Aladdin/Blackrock Adding Aladdin/Blackrock - DO NOT MERGE Nov 5, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 5, 2024 •
edited
Loading

✅ Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit 7c0fb63
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/678110a45aab640008eaa425
😎 Deploy Preview https://deploy-preview-1413--fdc3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@robmoffat robmoffat requested a review from kemerava November 5, 2024 10:54
@robmoffat
Copy link
Member Author

@kemerava ???

@robmoffat robmoffat closed this Nov 26, 2024
@robmoffat robmoffat reopened this Nov 26, 2024
@kemerava
Copy link
Contributor

kemerava commented Nov 27, 2024 •
edited
Loading

@kemerava ???

Sorry, @robmoffat, still waiting on the team to review

@robmoffat robmoffat changed the title Adding Aladdin/Blackrock - DO NOT MERGE Adding Aladdin/Blackrock Jan 10, 2025
@robmoffat
Copy link
Member Author

@kemerava - can you merge this please?

@robmoffat
Copy link
Member Author

@kemerava @kriswest please add your review and let's get this one closed, thanks

kemerava
kemerava approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@kemerava kemerava left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Sitija approved) Thank you so much @robmoffat

kriswest
kriswest approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest merged commit cbf3aeb into main Jan 14, 2025
10 checks passed
@kriswest kriswest deleted the aladdin-conformance branch January 14, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemerava kemerava kemerava approved these changes

@kriswest kriswest kriswest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robmoffat @kemerava @kriswest