Skip to content

Commit

Permalink
Add missing id, name fields to json schema docs
Browse files Browse the repository at this point in the history
Added the optional id and name fields which are documented on the FINOS
site but currently missing from OrderList, InstrumentList, ContactList
and Contact (name only).
  • Loading branch information
hellosmithy committed Jun 27, 2024
1 parent dcd98c2 commit 13ccdd2
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 3 deletions.
4 changes: 4 additions & 0 deletions schemas/context/contact.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
"description": "FactSet Permanent Identifier representing the contact"
}
}
},
"name": {
"type": "string",
"description": "An optional human-readable name for the contact"
}
},
"required": [
Expand Down
14 changes: 13 additions & 1 deletion schemas/context/contactList.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@
"type": {
"const": "fdc3.contactList"
},
"id": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"title": "Contact List Identifiers",
"description": "One or more identifiers that refer to the contact list in an OMS, EMS or related system. Specific key names for systems are expected to be standardized in future."
},
"name": {
"type": "string",
"description": "An optional human-readable summary of the contact list"
},
"contacts": {
"type": "array",
"title": "List of Contacts",
Expand Down Expand Up @@ -47,4 +59,4 @@
]
}
]
}
}
14 changes: 13 additions & 1 deletion schemas/context/instrumentList.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@
"type": {
"const": "fdc3.instrumentList"
},
"id": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"title": "Instrument List Identifiers",
"description": "One or more identifiers that refer to the instrument list in an OMS, EMS or related system. Specific key names for systems are expected to be standardized in future."
},
"name": {
"type": "string",
"description": "An optional human-readable summary of the instrument list"
},
"instruments": {
"type": "array",
"title": "List of instruments",
Expand Down Expand Up @@ -48,4 +60,4 @@
]
}
]
}
}
14 changes: 13 additions & 1 deletion schemas/context/orderList.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@
"type": {
"const": "fdc3.orderList"
},
"id": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"title": "Order List Identifiers",
"description": "One or more identifiers that refer to the order list in an OMS, EMS or related system. Specific key names for systems are expected to be standardized in future."
},
"name": {
"type": "string",
"description": "An optional human-readable summary of the order list"
},
"orders": {
"type": "array",
"items": {
Expand Down Expand Up @@ -46,4 +58,4 @@
]
}
]
}
}

0 comments on commit 13ccdd2

Please sign in to comment.