Fix single test execution #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmoffat
requested changes
Jul 3, 2023
| @@ -34,7 +34,7 @@ function executeTests() { | |||
| } | |||
|
|
|||
| function returnToTestSelection() { | |||
| location.reload(); | |||
| location.href = '/v1.2/app/index.html'; | |||
There was a problem hiding this comment.
In Sail location.reload() and location.href are not working.
Single test execution is still broken in Sail.
On clicking the button, it opens up the tests in Browser.
There was a problem hiding this comment.
anything to do with scoping? window.location and location are not necessarily the same thing depending on which scope you are in.
| @@ -73,6 +72,31 @@ function toggleBackButton() { | |||
| } | |||
| } | |||
|
|
|||
| function executeSingleTest(testName: string, manualTest: boolean) { | |||
There was a problem hiding this comment.
this looks like it's repeated code
There was a problem hiding this comment.
I can sort it out and make it as one function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.