modular-services: update and cleanup - #2
Open
Eveeifyeve wants to merge 4 commits into
Open
Conversation
Author
|
Fixed in fbaf359 |
Eveeifyeve
force-pushed
the
update-and-cleanup
branch
from
July 25, 2026 18:46
648d132 to
fbaf359
Compare
aanderse
requested changes
Jul 25, 2026
aanderse
left a comment
aanderse
left a comment
Member
There was a problem hiding this comment.
thanks for contributing! just a few small things to clean up
hopefully i can get a vm test up and running to validate this...
|
|
||
| finix.reload = mkOption { | ||
| type = types.nullOr types.str; | ||
| default = if config.process.reloadCommand != null then config.process.reloadCommand else ""; |
Member
There was a problem hiding this comment.
Suggested change
| default = if config.process.reloadCommand != null then config.process.reloadCommand else ""; | |
| default = if config.process.reloadCommand != null then config.process.reloadCommand else null; |
wouldn't null be better than empty string here?
| type = types.str; | ||
| default = lib.escapeShellArgs config.process.argv; | ||
| defaultText = lib.literalExpression "config.process.reloadCommand"; | ||
| description = ""; |
| type = types.nullOr types.str; | ||
| default = if config.process.reloadCommand != null then config.process.reloadCommand else ""; | ||
| defaultText = lib.literalExpression "config.process.reloadCommand"; | ||
| description = ""; |
| finit.services."" = { | ||
| command = config.finit.command; | ||
| reload = config.finit.reload; | ||
| notify = |
Member
There was a problem hiding this comment.
++is list concatenation operator, not stringfinitonly accepts a single value, so you should is anif...elseexpression- give
systemdthe highest preference ✔️
| notify = | ||
| lib.optionalString config.notificationProtocol.systemd "systemd" | ||
| ++ lib.optionalString config.notificationProtocol.s6 "s6"; | ||
| conditions = lib.mkIf (config.notificationProtocol.systemd || config.notificationProtocol.s6) [ |
Member
There was a problem hiding this comment.
you can drop the conditional here and simply set the value
| description = ""; | ||
| }; | ||
|
|
||
| finix.reload = mkOption { |
Member
There was a problem hiding this comment.
Suggested change
| finix.reload = mkOption { | |
| finit.reload = mkOption { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for modular service apis to finix:
process.reloadCommand/process.reloadSignal¬ificationProtocol.Relating ref: