Merge pull request #292 from fingerprintjs/fix-cleanup-pipeline

Move region from secrets to vars
fingerprintjs · Sep 20, 2024 · 5330a64 · 5330a64
2 parents 8a01eff + 0636fb3
commit 5330a64
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/cleanup-staled-aws-e2e-resources.yml b/.github/workflows/cleanup-staled-aws-e2e-resources.yml
@@ -20,7 +20,7 @@ jobs:
         uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 #v4.0.2
         with:
           role-to-assume: ${{secrets.AWS_E2E_ROLE_ARN}}
-          aws-region: ${{secrets.AWS_E2E_REGION}}
+          aws-region: ${{vars.AWS_E2E_REGION}}
       - name: Trigger AWS CodePipeline
         run: |
           codepipeline_execution_id=$(aws codepipeline start-pipeline-execution --name ${{vars.AWS_CLEANUP_E2E_LAMBDAS_CODEPIPELINE_NAME}} --query 'pipelineExecutionId' --output text)
@@ -49,7 +49,7 @@ jobs:
       - name: Output Pipeline Link
         if: always()
         run: |
-          region=${{ secrets.AWS_E2E_REGION }}
+          region=${{ vars.AWS_E2E_REGION }}
           pipeline_name=${{ vars.AWS_CLEANUP_E2E_LAMBDAS_CODEPIPELINE_NAME }}
           execution_id=${{ env.codepipeline_execution_id }}
           pipeline_url="https://${region}.console.aws.amazon.com/codesuite/codepipeline/pipelines/${pipeline_name}/executions/${execution_id}?region=${region}"

diff --git a/.github/workflows/deploy_test_branch.yml b/.github/workflows/deploy_test_branch.yml
@@ -79,7 +79,7 @@ jobs:
         uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 #v4.0.2
         with:
           role-to-assume: ${{secrets.AWS_E2E_ROLE_ARN}}
-          aws-region: ${{secrets.AWS_E2E_REGION}}
+          aws-region: ${{vars.AWS_E2E_REGION}}
       - name: Trigger AWS CodePipeline
         run: |
           codepipeline_execution_id=$(aws codepipeline start-pipeline-execution --name ${{vars.AWS_E2E_TEST_BRANCH_CODEPIPELINE_NAME}} --query 'pipelineExecutionId' --output text)

diff --git a/.github/workflows/e2e_test_for_releases.yml b/.github/workflows/e2e_test_for_releases.yml
@@ -24,7 +24,7 @@ jobs:
         uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 #v4.0.2
         with:
           role-to-assume: ${{secrets.AWS_E2E_ROLE_ARN}}
-          aws-region: ${{secrets.AWS_E2E_REGION}}
+          aws-region: ${{vars.AWS_E2E_REGION}}
       - name: Trigger AWS CodePipeline
         run: |
           codepipeline_execution_id=$(aws codepipeline start-pipeline-execution --name ${{vars.AWS_E2E_RC_CODEPIPELINE_NAME}} --query 'pipelineExecutionId' --output text)