Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build separate bundle for React Native #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Andarist
Copy link
Contributor

If you like the change I'll have to adjust the tests - didnt want to do that now, because aint sure if you dig this 😉

I'm also unsure if my changes are correct, would love you to look on them and validate it.

) => {
if (
!isReactNative &&
event.nativeEvent &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when event.nativeEvent.text is present in non-RN environment (I'm assuming browser target)?

currentValue: any,
valueProp: any,
) => {
if (event.nativeEvent) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've extracted this bit from the previous version of getValue, but it seems wrong to me, I have 0 experience with React Native though, so cant validate it :/

maybe this should be just

const getValue = (event, currentValue, valueProp) => event.nativeEvent.text

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have zero RN experience. Maybe we should find someone who does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @MichelDiz @rafaelcorreiapoli @geowarin @erickjth @bogdansoare @ibratoev @cosmith @maciejmyslinski @ghoshabhi

I think you guys were using (at least at some point in time) this library in RN. Could you take a look at this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never used react-final-form with react native. I asked my friends who code in react native for help, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Sorry for pinging you then, I've looked through RN-related topics and pinged everyone who was involved.

@crobinson42
Copy link

I have react-final-form working fine in react-native 0.60 on both Android and iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants