Skip to content

Conversation

@ireznice
Copy link

No description provided.

@lksv
Copy link
Contributor

lksv commented Aug 17, 2015

thanks you for big work.

please do following:

  • remove all czech (debug) texts (and such things like echo $VERSION, echo $(cat .current-commit) and echo "Foreman exited, finishing....")
  • in base-image: move setting ENV variables to init.sh. The reason is to be able to set only RAILS_ENV during starting docker and all the other variables (FINAL_DATABASE) will be set according the RAILS_ENV. Please note that you will need to call source ../start.sh. Set variables only if they are not already exists. (note: I prefer use ENV or (or instead of) RAILS_ENV).
  • remove start, init.sh and prepare_version.sh form all other docker images if they are not modified.
  • fix README.md
  • EXPOSE and VOLUME all services/data dirs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is necessary to update User if already exists.

@ireznice ireznice force-pushed the fa_docker_images branch 4 times, most recently from d1721cd to ef21fe2 Compare August 24, 2015 13:44
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure...
Make sence to move settings this variables to env.sh and here simply source env.sh ?

prefer to use "default value", e.g. USER=${USER:-"travis"}

@ireznice ireznice force-pushed the fa_docker_images branch 4 times, most recently from f975782 to 87d3716 Compare August 28, 2015 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants