Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt the user to delete the profile when deleting its last site #422

Merged
merged 4 commits into from
Nov 18, 2023
Merged

Prompt the user to delete the profile when deleting its last site #422

merged 4 commits into from
Nov 18, 2023

Conversation

iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Nov 16, 2023

Fix #407

@iTrooz
Copy link
Contributor Author

iTrooz commented Nov 16, 2023

Draft because I modified a message I'm not sure about (#407 (comment))

@iTrooz iTrooz marked this pull request as draft November 16, 2023 20:49
@iTrooz
Copy link
Contributor Author

iTrooz commented Nov 16, 2023

Ready for review

@iTrooz iTrooz marked this pull request as ready for review November 16, 2023 20:53
@filips123 filips123 self-requested a review November 18, 2023 18:05
filips123
filips123 approved these changes Nov 18, 2023
View reviewed changes
Copy link
Owner

@filips123 filips123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@filips123 filips123 merged commit 54a2899 into filips123:main Nov 18, 2023
2 checks passed
@filips123 filips123 added the enhancement New feature or request label Nov 18, 2023
@filips123 filips123 added this to the 2.9.0 milestone Nov 18, 2023
@iTrooz iTrooz deleted the auto_del_profile branch November 19, 2023 00:07
@iTrooz
Copy link
Contributor Author

iTrooz commented Nov 19, 2023

You're welcome, thanks for answering quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filips123 filips123 filips123 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
PWAsForFirefox
Status: Done
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

Option to delete profile when deleting its last PWA
2 participants
@iTrooz @filips123