fix(Makefile): use PROJECT_NAME and keep coverage output in build dir#53
Open
DehanLUO wants to merge 1 commit intofilipdutescu:masterfrom
Open
fix(Makefile): use PROJECT_NAME and keep coverage output in build dir#53DehanLUO wants to merge 1 commit intofilipdutescu:masterfrom
DehanLUO wants to merge 1 commit intofilipdutescu:masterfrom
Conversation
- Introduce PROJECT_NAME := Project to avoid hardcoding project name in CMake options - Replace hardcoded names like modern-cpp-template_ENABLE_... with $(PROJECT_NAME)_ENABLE_... - run gcov inside the build/ directory so .gcov files are not spilled into the project root - Fix issue#39 Improves maintainability and keeps generated files isolated in the build directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves maintainability and keeps generated files isolated in the build directory.