Skip to content

Fix: Launch files from jar archives #18554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marko1olo wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

Fix: Launch files from jar archives #18554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/Files.App/Helpers/Navigation/NavigationHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,24 @@ private static async Task<FilesystemResult> OpenFile(string path, IShellPage ass
if (!launchSuccess)
await Win32Helper.InvokeWin32ComponentAsync(path, associatedInstance, args);
}
else if (childFile.Item is ZipStorageFile zipStorageFile)
{
var options = InitializeWithWindow(new LauncherOptions());
var storageItem = (StorageFile)await FilesystemTasks.Wrap(() => zipStorageFile.ToStorageFileAsync().AsTask());
if (storageItem is null)
{
await Win32Helper.InvokeWin32ComponentAsync(path, associatedInstance, args);
}
else if (!await Launcher.LaunchFileAsync(storageItem, options))
{
var pickerOptions = InitializeWithWindow(new LauncherOptions
{
DisplayApplicationPicker = true
});
if (!await Launcher.LaunchFileAsync(storageItem, pickerOptions))
await Win32Helper.InvokeWin32ComponentAsync(path, associatedInstance, args);
}
}
else
{
await Win32Helper.InvokeWin32ComponentAsync(path, associatedInstance, args);
Expand Down