Code Quality: Simplified loading of logical drives and network locations in the Home widges #17102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
changed the title
yaira2
reviewed
May 8, 2025
yaira2
reviewed
May 8, 2025
| @@ -204,43 +212,29 @@ private void ExecuteOpenPropertiesCommand(WidgetDriveCardItem? item) | |||
| flyout!.Closed += flyoutClosed; | |||
| } | |||
|
|
|||
| private void ExecuteDisconnectNetworkDriveCommand(WidgetDriveCardItem? item) | |||
There was a problem hiding this comment.
Is this command not being used? If it's not, we should look at the commit history to see what happened.
There was a problem hiding this comment.
Yeah, thought the same. I'll look into.
yaira2
reviewed
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes