Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shed): lotus-shed sectors dump-sectors #12703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Nov 19, 2024

Most of the fields in SectorOnChainInfo for all of the records on chain (using the power actor to list miners and then listing all of their sectors). No filtering so far, output as CSV. Currently doesn't print the two CIDs. This came up as part of the FIP-0096 (or whatever number this will get filecoin-project/FIPs#1079) discussions looking at termination fees and I wanted to collect some data for it.

@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Nov 19, 2024
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main shed command looks fine but Id like to understand why you are changing
the loadChainStore function to explicitly assume splitstore things.

}

path, err := lkrepo.SplitstorePath()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is going on here ? What was breaking that made you change this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you open universal blockstore it should be wrapped around all of the splitstore right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZenGround0: when using the original I couldn't get it to run - when it initialised and figured out what the latest head is (from the metadata store) it would then try and load that tipset but fail with not-found errors. Switching to this makes it work. My assumption is that this works fine for a non-splitstore setup, but breaks when using a splitstore, and nobody running splitstore has been using the commands that use this code until I tried it.

Both patterns are found throughout lotus-shed, I copied a lot of this new stuff from elsewhere. I'd like to understand it a bit better to make it consistent throughout, maybe just make a helper function for this. But I haven't taken the time to bother going that deep yet. If you have more of a clue then I'm all ears!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: 🔎 Awaiting review
Development

Successfully merging this pull request may close these issues.

2 participants