Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add max results error and default raw codec for eth_getLogs #12671

Merged

Conversation

akaladarshi
Copy link
Contributor

Related Issues

#12636

Proposed Changes

  • Adds raw codec while filtering ethereum logs
  • Error out if we hit max result

Checklist

Before you mark the PR ready for review, please make sure that:

chain/index/events.go Outdated Show resolved Hide resolved
@akaladarshi akaladarshi marked this pull request as ready for review November 7, 2024 09:01
CHANGELOG.md Outdated Show resolved Hide resolved
chain/index/events.go Outdated Show resolved Hide resolved
node/impl/full/eth.go Outdated Show resolved Hide resolved
chain/index/interface.go Outdated Show resolved Hide resolved
@akaladarshi akaladarshi force-pushed the akaladarshi/fix-max-filter-result branch 2 times, most recently from 3c9197f to 5251de7 Compare November 19, 2024 07:19
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@rvagg rvagg enabled auto-merge (squash) November 20, 2024 10:35
@rvagg rvagg merged commit 4f92348 into filecoin-project:master Nov 20, 2024
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants