-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add max results error and default raw codec for eth_getLogs #12671
Merged
rvagg
merged 6 commits into
filecoin-project:master
from
akaladarshi:akaladarshi/fix-max-filter-result
Nov 20, 2024
Merged
fix: add max results error and default raw codec for eth_getLogs #12671
rvagg
merged 6 commits into
filecoin-project:master
from
akaladarshi:akaladarshi/fix-max-filter-result
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Nov 7, 2024
rvagg
reviewed
Nov 18, 2024
rvagg
reviewed
Nov 18, 2024
rvagg
reviewed
Nov 18, 2024
rvagg
reviewed
Nov 18, 2024
akaladarshi
force-pushed
the
akaladarshi/fix-max-filter-result
branch
2 times, most recently
from
November 19, 2024 07:19
3c9197f
to
5251de7
Compare
rvagg
requested changes
Nov 20, 2024
akaladarshi
force-pushed
the
akaladarshi/fix-max-filter-result
branch
from
November 20, 2024 05:00
275acc4
to
b2b1ef9
Compare
rvagg
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#12636
Proposed Changes
Checklist
Before you mark the PR ready for review, please make sure that: