-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(miner): ignore lastWork when selecting the best mining candidate + tests #12659
base: master
Are you sure you want to change the base?
Commits on Oct 30, 2024
-
fix(miner): ignore lastWork when selecting the best mining candidate
Previously, we only took the new head if it's heavier than the last head. Unfortunately, this meant that F3 finalization wasn't properly propagated to the miner. In terms of impact: 1. It seems likely that this check was simply defensive as, prior to F3, the new head should never have a lower weight (unless you're talking to multiple lotus nodes, I guess...). 2. The `lastWork` field is mostly used to track null blocks. Worst-case scenario, if we switch heads, we'll attempt to re-mine previous heights. However, that should be relatively fast and, due to the slash filter, we won't attempt to re-broadcast any of those blocks.
Configuration menu - View commit details
-
Copy full SHA for e1a0572 - Browse repository at this point
Copy the full SHA e1a0572View commit details
Commits on Nov 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c80f32d - Browse repository at this point
Copy the full SHA c80f32dView commit details -
[WIP] test: checkpoint to a fork
This test still doesn't pass and I'm not sure why: 1. Sync is a bit broken because it can't figure out that we already have all the data locally. 2. But with 2 nodes, it should work. Except that, if I add some logging, I see that sync works until the libp2p nodes just flat-out disconnect from eachother.
Configuration menu - View commit details
-
Copy full SHA for 4404614 - Browse repository at this point
Copy the full SHA 4404614View commit details
Commits on Nov 5, 2024
-
fix(miner): check the slash filter with the correct parent height
We also perform this check inside `SyncSubmitBlock` so we did have an effective filter, but this was still wrong.
Configuration menu - View commit details
-
Copy full SHA for 065df6a - Browse repository at this point
Copy the full SHA 065df6aView commit details -
fix(exchange): avoid adding ourselves as an exchange peer
We have some cases where we submit a tipset to ourselves, from ourselves and end up calling `AddPeer` with our own ID. Ignore this case.
Configuration menu - View commit details
-
Copy full SHA for d5a45ba - Browse repository at this point
Copy the full SHA d5a45baView commit details -
fix(hello): submit new blocks from peers even if we're at genesis
A side-effect of InformNewHead is to record the peer for future chain-sync sessions. If we don't pass blocks to InformNewHead here, we can have some difficulty bootstrapping networks.
Configuration menu - View commit details
-
Copy full SHA for 475eda5 - Browse repository at this point
Copy the full SHA 475eda5View commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8d4a555 - Browse repository at this point
Copy the full SHA 8d4a555View commit details