Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fvm: update FFI to not arbitrary limit FVM concurrency #11867

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Apr 10, 2024

Related Issues

fixes #11817

Proposed Changes

  1. Set the default FVM concurrency limit equal to the number of available CPU threads.
  2. Ensure the FVM's thread-pool doesn't limit the amount of available concurrency by allocating LOTUS_FVM_CONCURRENCY threads.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@Stebalien Stebalien marked this pull request as draft April 10, 2024 17:54
@Stebalien
Copy link
Member Author

I want to think about this a bit. We may need separate memory limits.

High values are now usually OK because we "oversubscribe" fvm instances.
The old warning of 24 is now equivalent to 1k+.
Copy link

github-actions bot commented Jun 19, 2024

All checks have passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase LOTUS_FVM_CONCURRENCY
1 participant