Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt publication with circuit breaker #713

Closed
wants to merge 1 commit into from
Closed

Attempt publication with circuit breaker #713

wants to merge 1 commit into from

Commits on Oct 9, 2024

  1. Attempt publication with circuit breaker 

    GPBFT silently ignores broadcast and rebroadcast requests as it is
beyond its boundaries of responsibility to do something about. In
practice such failures may be a sign that pubsub is overwhelmed with
messages. Therefore, ideally the system should avoid aggravating the
situation by requesting further broadcasts. This is specially important
in re-broadcast requests because it often involves batch message
publication.

The changes here wrap the pubsub publication calls with a circuit
breaker that will open on consecutive errors (set to `5`), and will not
attempt to actually publish messages until a reset timeout (set to `3s`)
has passed.

Fixes #632
    @masih
    masih committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f003b1f View commit details
    Browse the repository at this point in the history