Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay static manifest until our head is within the target period #696

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Stebalien
Copy link
Member

Unfortunately, due to filecoin-project/lotus#12557, time in our lotus tests is basically broken. So we start by relying on time but also check the head so we don't switch too early.

This doesn't matter in practice, but I'd really like to be able to test this in CI, fully integrated.

Unfortunately, due to
filecoin-project/lotus#12557, time in our
lotus tests is basically broken. So we start by relying on time but also
check the head so we don't switch too early.

This doesn't matter in practice, but I'd really like to be able to test
this in CI, fully integrated.
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 75.91%. Comparing base (2731818) to head (0a3aa14).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manifest/fusing_provider.go 21.42% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   76.58%   75.91%   -0.68%     
==========================================
  Files          69       69              
  Lines        5582     5596      +14     
==========================================
- Hits         4275     4248      -27     
- Misses        896      930      +34     
- Partials      411      418       +7     
Files with missing lines Coverage Δ
manifest/fusing_provider.go 68.49% <21.42%> (-11.17%) ⬇️

... and 7 files with indirect coverage changes

@Stebalien Stebalien requested a review from Kubuxu October 4, 2024 20:41
@Stebalien Stebalien added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 56976f0 Oct 4, 2024
12 of 13 checks passed
@Stebalien Stebalien deleted the steb/delay-static-manifest branch October 4, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants