Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filecoin-project.yml to make this repo public #46

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

BigLep
Copy link
Member

@BigLep BigLep commented Jul 20, 2024

Closes #45

NOTE: wait to merge until filecoin-project/community#710 is given some time for comment.

Summary

Make this repo public per #45

Why do you need this?

See #45

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@BigLep BigLep self-assigned this Jul 20, 2024
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
There will be no access changes

Copy link
Contributor

github-actions bot commented Jul 20, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

filecoin-project

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_repository.this["github-mgmt"] will be updated in-place
  ~ resource "github_repository" "this" {
        id                          = "github-mgmt"
        name                        = "github-mgmt"
      ~ visibility                  = "private" -> "public"
        # (31 unchanged attributes hidden)

      + security_and_analysis {

          + secret_scanning {
              + status = "enabled"
            }

          + secret_scanning_push_protection {
              + status = "enabled"
            }
        }

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@BigLep
Copy link
Member Author

BigLep commented Aug 1, 2024

@galargh : I think we'd be good to flip this public now given no pushback in filecoin-project/community#710

@galargh
Copy link
Contributor

galargh commented Aug 5, 2024

After the merge, let's require approval for all outside collaborators. This setting is not available for private repositories - that's why it wasn't set before.

@BigLep BigLep merged commit ae01754 into master Aug 5, 2024
6 checks passed
@BigLep
Copy link
Member Author

BigLep commented Aug 5, 2024

@galargh : I have merged. I don't have the ability to adjust setting in the UI since I'm not an org owner/admin and I currently only have push access. (I'll give github-mgmt stewards maintain or admin permissions to this repo when handling #47 . Are you ok to handle in the meantime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make this repo public
2 participants