-
Notifications
You must be signed in to change notification settings - Fork 32
Apply dyn-cfg to p1 cases #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snadrus
wants to merge
39
commits into
main
Choose a base branch
from
apply-dyn-cfg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make our Ingest & Address configuration dynamic such that the values apply instantly.
Market will ERROR on 0 <--> 1 that a restart is required to enable the correct services.
Discoveries
Computed Values: These become their own config.NewDynamic() which gets updated by a callback on the source(s).
I could be persuaded to turn these into event streams into reactive programming: https://github.com/samber/ro
I don't think we should be stopping & starting services on these changes. That will simply be unsupported.
Bad configuration is setup to throw error and reuse the original in all the secondary-interpretations, otherwise it'll stream out errors until fixed in the direct consumptions. These seem reasonable.
I couldn't get TOML to do value unmarshal as it knows documents only at the top level, so I built an ugly wrapper full of reflection that we should use instead of TOML unmarshal. It works, but it's ugly.