Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer integration test #95

Merged
merged 5 commits into from
Sep 14, 2022
Merged

Transfer integration test #95

merged 5 commits into from
Sep 14, 2022

Conversation

abright
Copy link
Contributor

@abright abright commented Sep 6, 2022

Adds a new actor and integration test that mints and transfers tokens

@abright abright marked this pull request as ready for review September 6, 2022 09:00
@coveralls
Copy link

coveralls commented Sep 6, 2022

Coverage Status

Coverage remained the same at 76.025% when pulling 39fc914 on token/transfer-integration-test into 344a773 on main.

@abright abright force-pushed the token/transfer-integration-test branch from 571aeec to d1d821f Compare September 8, 2022 00:45
}

#[no_mangle]
fn invoke(input: u32) -> u32 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you describe the basic behaviour that this implements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment describing how the actor works


let ret_val =
tester.call_method(operator[0].1, receiver_address, method_hash!("Constructor"), None);
println!("receiving actor constructor return data: {:#?}", &ret_val);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of boilerplate here that makes it hard to identify the important code. Could you factor some out so that the core test is more to the point?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will follow this up in #103 as it already has a bunch of improvements to the setup boilerplate code

@abright abright mentioned this pull request Sep 12, 2022
11 tasks
@abright abright force-pushed the token/transfer-integration-test branch from d1d821f to 9c41e14 Compare September 14, 2022 04:27
@abright abright force-pushed the token/transfer-integration-test branch from 9c41e14 to 39fc914 Compare September 14, 2022 06:07
@abright abright merged commit 8f95e9f into main Sep 14, 2022
@abright abright deleted the token/transfer-integration-test branch September 14, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants