Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Toolchain #217

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Stable Toolchain #217

merged 5 commits into from
Jul 5, 2023

Conversation

alexytsu
Copy link
Collaborator

@alexytsu alexytsu commented Jul 5, 2023

  • move integration tests in the src tree
  • migrate frc46_test_actor to new build
  • migrate integration test actors to the new build script

TODO in followup: #218

@alexytsu alexytsu marked this pull request as ready for review July 5, 2023 08:33
@alexytsu alexytsu changed the title WIP Stable Toolchain Stable Toolchain Jul 5, 2023
@coveralls
Copy link

Coverage Status

coverage: 87.128% (+0.4%) from 86.776% when pulling 45848ed on alex/stable-toolchain into bf90078 on main.

@@ -0,0 +1,4 @@
[toolchain]
channel = "stable"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the downside of specifying stable is that CI will break every time rust releases a new version and adds additional warnings. The upside is that you instantly get notified of new warnings/issues, it can just be a little annoying when you're trying to merge a PR and suddenly CI decides to break for unrelated reasons).

@alexytsu alexytsu merged commit acd5920 into main Jul 5, 2023
@alexytsu alexytsu deleted the alex/stable-toolchain branch July 5, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants