Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BASE_URL to point to current API endpoint #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remuslazar
Copy link

Obviously the API endpoint has been changed, see #46 (comment)

Fixes #46

Obviously the API endpoint has been changed, see filcole#46 (comment)
@stuartleeks
Copy link

I was seeing the same issue as in #46 . I manually applied this change to my local package and can confirm that it resolves the API issue for me 👍

@remuslazar
Copy link
Author

@filcole any chance to integrate this patch into the next HA core release?

@michael-hermsen
Copy link

? Any update on this?
(Got the same problem)

But was waiting for a Patch.

looks like @filcole is not really Active anymore??

Is this gona be another Dead Repo?

Copy link

@michael-hermsen michael-hermsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it works.

Edited the base url locally and it works again.

@depulle87
Copy link

Can confirm it works.

Edited the base url locally and it works again.

Where do I apply this fix to update the URl?

@michael-hermsen
Copy link

michael-hermsen commented Jun 5, 2024

See the api stopped working above and scroll to the bottom, there is a explanation at how to edit it for HAOS.

Or use the reference link below:
#46 (comment)

@remuslazar
Copy link
Author

@filcole ping

@JohnMcLear
Copy link

JohnMcLear commented Jun 20, 2024

another ping @filcole

@JohnMcLear
Copy link

Thanks @fereehu

@neoKushan
Copy link

Unfortunately @JohnMcLear anyone can approve a PR, but @filcole needs to merge it in.

@JohnMcLear
Copy link

@neoKushan indeed I think it is @filcole who needs to be pinged a bit more.. Do you think so too? :)

@JohnMcLear
Copy link

JohnMcLear commented Jul 4, 2024

I think at the 2 month mark we should fork because I think @filcole maybe has other priorities right now.. Any objections? July 18 would be 2 months from when this PR was opened, if it was something minor I'd get it but currently the software is broken..

@remuslazar
Copy link
Author

Just a quick note here:

I'm currently developing a new, improved implementation of this library that uses async network communication. Additionally, I've started a custom integration for Home Assistant (HASS) based on this new library. This integration aims to replace the core nissan_leaf integration.

The new integration will offer several advantages over the original, such as being fully configurable via UI, no secrets in YAML files, and a smoother experience through async calls.

Currently is in its early alpha stage, but I aim to have it in a stable beta state by the end of this or next week for external testing. I also plan to release it on HACS soon.

@JohnMcLear
Copy link

@remuslazar is it time to switch? Are you still in active dev or?

@remuslazar
Copy link
Author

remuslazar commented Jul 18, 2024

@JohnMcLear you can try this one, currently in the beta stage: https://github.com/remuslazar/homeassistant-carwings

@michael-hermsen
Copy link

Integrated succesfully so far, happy to test it out. No problems sinds someone shared your link ;)

@JohnMcLear
Copy link

@JohnMcLear you can try this one, currently in the beta stage: https://github.com/remuslazar/homeassistant-carwings

Confirmed working

@mekrapp
Copy link

mekrapp commented Sep 9, 2024

@filcole
I am still interested to use your original pycarwings2 library in another project. Please merge the proposed change to your code.

@remuslazar
Copy link
Author

@mekrapp you could take a look at https://github.com/ev-freaks/pycarwings3 as an alternative. I think, this here is dead

@mekrapp
Copy link

mekrapp commented Sep 9, 2024

@remuslazar thanks for the link to your proposed alternative. I will check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API stopped working: "The requested URL /api_v210707_NE/gdc/InitialApp_v2.php was not found on this server."
9 participants