fix: allow MaxWidth enum instance
#14996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getMaxWidth()` method is compatible with handling the `MaxWidth` enum. Previously, it was not possible to use `MaxWidth` enum instances when overwriting the `$maxWidth` property. Note: This change was not applied to the `3.x` branch as it introduces a breaking change. The change may impact classes extending `SimplePage` or `EditProfile` if the `maxWidth` property has already been overridden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
getMaxWidth()method is compatible with handling theMaxWidthenum. Previously, it was not possible to useMaxWidthenum instances when overwriting the$maxWidthproperty.Note: This change was not applied to the
3.xbranch as it introduces a breaking change. The change may impact classes extendingSimplePageorEditProfileif themaxWidthproperty has already been overridden.Functional changes
composer cscommand.