-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/vertical tabs #14436
Add/vertical tabs #14436
Conversation
allow vertical tab orientation
when can see v4 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bender-0 can you please rebase these changes onto v4? The Blade components have been refactored and the Tailwind classes are now in CSS files
Hi, i made PR for vertical Wizard in v3, but it was closed for new features. If someone wants to rebase/refactor/use it for v4... It feels similar to the vertical Tabs situation, including Discussion: #13894 PS: Feel free to do whatever with the old PR, sadly I won't have time for this anytime soon (probably not until v4 is out and i will be considering upgrade of my project, which currently uses the css override from the discussion) |
Alright no worries, thanks for letting me know! |
@danharrin This might be a misunderstanding, I am not author of this PR (vertical Tabs), @Bender-0 is. I only tried to link it to my old PR (vertical Wizard) as it felt related, so they could implement the vertical style for more components than just Tabs). I would like v4 to have vertical styles/layouts, so please reconsider reopening this and waiting for Bender / someone to finish it Sorry for the confusion |
…tton-tooltip fix: Disabled button tooltip
…s-page-edit-permission feature: Settings page edit permission
…n-manager-page-generation Improve relation manager/relation page generation
…ng-case-consistency fix: Modal heading case consistency
…el-no-default fix: Do not return default panel as current automatically
@danharrin so i pulled and rebased onto 4.x and created a new empty commit "rebased onto 4.x ". |
@Bender-0 please follow these steps: First, update your fork by going to your fork's Github page and pressing "Sync Fork" From your terminal:
You'll see the conflicts. PS: the |
Description
Adds a vertical orientation option for Tabs component
Visual changes
Before
After
Functional changes
composer cs
command.