Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/vertical tabs #14436

Closed
wants to merge 163 commits into from
Closed

Add/vertical tabs #14436

wants to merge 163 commits into from

Conversation

Bender-0
Copy link

@Bender-0 Bender-0 commented Oct 3, 2024

Description

Adds a vertical orientation option for Tabs component

Visual changes

Before

image

After

image

Tabs::make('Tabs')
    ->vertical() // Makes the tabs display vertically
    ->tabs([
        Tabs\Tab::make('Tab 1')
            ->schema([
                // ...
            ]),
        Tabs\Tab::make('Tab 2')
            ->schema([
                // ...
            ]),
        Tabs\Tab::make('Tab 3')
            ->schema([
                // ...
            ]),
    ])

Functional changes

  • [✓] Code style has been fixed by running the composer cs command.
  • [✓] Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

allow vertical tab orientation
@Bender-0 Bender-0 requested a review from saade as a code owner October 3, 2024 15:40
@Bender-0 Bender-0 changed the base branch from 3.x to 4.x October 3, 2024 15:42
@danharrin danharrin added this to the v4 milestone Oct 7, 2024
@NazarAli
Copy link

when can see v4 ?

@danharrin danharrin requested a review from zepfietje December 3, 2024 09:16
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bender-0 can you please rebase these changes onto v4? The Blade components have been refactored and the Tailwind classes are now in CSS files

@vikijel
Copy link
Contributor

vikijel commented Dec 3, 2024

Hi, i made PR for vertical Wizard in v3, but it was closed for new features.

If someone wants to rebase/refactor/use it for v4...

It feels similar to the vertical Tabs situation, including ->vertical() method on Wizard.

Discussion: #13894
PR for v3: #13919

PS: Feel free to do whatever with the old PR, sadly I won't have time for this anytime soon (probably not until v4 is out and i will be considering upgrade of my project, which currently uses the css override from the discussion)

@danharrin
Copy link
Member

Alright no worries, thanks for letting me know!

@danharrin danharrin closed this Dec 3, 2024
@vikijel
Copy link
Contributor

vikijel commented Dec 3, 2024

Alright no worries, thanks for letting me know!

@danharrin This might be a misunderstanding, I am not author of this PR (vertical Tabs), @Bender-0 is.

I only tried to link it to my old PR (vertical Wizard) as it felt related, so they could implement the vertical style for more components than just Tabs).

I would like v4 to have vertical styles/layouts, so please reconsider reopening this and waiting for Bender / someone to finish it

Sorry for the confusion

@Bender-0
Copy link
Author

Bender-0 commented Dec 22, 2024

@danharrin so i pulled and rebased onto 4.x and created a new empty commit "rebased onto 4.x ".
on my terminal git says everything up-to-date. but i still see the conflicts here and not sure why... any idea why is that? Am i missing something?

@saade
Copy link
Member

saade commented Dec 23, 2024

@Bender-0 please follow these steps:

First, update your fork by going to your fork's Github page and pressing "Sync Fork"

From your terminal:

git checkout 4.x
git pull
git checkout add/vertical-tabs
git merge 4.x

You'll see the conflicts.

PS: the schema package got renamed to schemas so you'll need move your changes to the correct location.

@Bender-0 Bender-0 closed this Dec 24, 2024
@Bender-0 Bender-0 deleted the add/vertical-tabs branch December 24, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.