-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show bulk actions below table #13530
Open
howdu
wants to merge
6
commits into
filamentphp:3.x
Choose a base branch
from
howdu:feature/bulk-actions-below-table
base: 3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
995ea9e
Add bulkActionsPosition to display below table
howdu eb71cee
chore: fix code style
howdu 9f99029
Update 05-actions.md
howdu 81ced0e
Merge branch '3.x' into feature/bulk-actions-below-table
howdu 7b634c5
Add bulk above and below option. Add footer bulk selections
howdu 9d1b666
chore: fix code style
howdu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<?php | ||
|
||
namespace Filament\Tables\Enums; | ||
|
||
enum BulkActionsPosition | ||
{ | ||
case AboveTable; | ||
|
||
case AboveAndBelowTable; | ||
|
||
case BelowTable; | ||
|
||
public function isAboveTable(): bool | ||
{ | ||
return match ($this) { | ||
self::AboveTable, self::AboveAndBelowTable => true, | ||
self::BelowTable => false, | ||
}; | ||
} | ||
|
||
public function isBelowTable(): bool | ||
{ | ||
return match ($this) { | ||
self::BelowTable, self::AboveAndBelowTable => true, | ||
self::AboveTable => false, | ||
}; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to minimize duplication here and in the header?
Maintenance of the table index view is already very hard, so I don't want to introduce additional complexity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zepfietje please let me know what changes you think best to improve this.
Perhaps using
capture
blade directive? But due to it not including the reorder action in the footer I think theselection-indicator
and bulk actionfilament-tables::actions
would need to be captured separately?