This repository has been archived by the owner on Jan 14, 2020. It is now read-only.
Revert "Do not include external modules in bundle" #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does that fix "Cannot call a class as a function"? |
|
Ooops, I was planning to merge this before the other PR, yep, it fixes it, although we have to find a better way to fix it, so leave the other issue for now |
|
Oh OK cool. np, it won't get included in the state dash until we unpin anyway. |
|
LGTM. |
patriciagarcia
force-pushed
the
revert-18-do-not-external-modules
branch
from
6317cf2
to
1b68bef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #18
See #20