Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented Oct 24, 2025

go-fdo-server also needs this for to0 too

@runcom runcom requested a review from mmartinv October 24, 2025 08:34
@runcom runcom force-pushed the ua-version branch 2 times, most recently from c0b94f2 to 5ac9cb9 Compare October 24, 2025 08:52
@runcom
Copy link
Member Author

runcom commented Oct 24, 2025

@mmartinv right now, the rpms produced in packit have VERSION=0 cause nothing sets that, I've modified that

@runcom runcom force-pushed the ua-version branch 4 times, most recently from b1a5cb0 to 7dd9edd Compare October 24, 2025 09:42
@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'go-fdo-client-fedora': {'value': {'fix-spec-file': ['Unknown field.']}}})}, 1: {'packages': defaultdict(<class 'dict'>, {'go-fdo-client-fedora': {'value': {'fix-spec-file': ['Unknown field.']}}})}, 2: {'packages': defaultdict(<class 'dict'>, {'go-fdo-client-fedora': {'value': {'fix-spec-file': ['Unknown field.']}}})}, 3: {'packages': defaultdict(<class 'dict'>, {'go-fdo-client-centos': {'value': {'fix-spec-file': ['Unknown field.']}}})}, 4: {'packages': defaultdict(<class 'dict'>, {'go-fdo-client-centos': {'value': {'fix-spec-file': ['Unknown field.']}}})}, 5: {'packages': defaultdict(<class 'dict'>, {'go-fdo-client-fedora': {'value': {'fix-spec-file': ['Unknown field.']}}})}, 6: {'packages': defaultdict(<class 'dict'>, {'go-fdo-client-centos': {'value': {'fix-spec-file': ['Unknown field.']}}})}}, 'packages': defaultdict(<class 'dict'>, {'go-fdo-client-fedora': {'value': {'fix-spec-file': ['Unknown field.']}}, 'go-fdo-client-centos': {'value': {'fix-spec-file': ['Unknown field.']}}})})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command config validate or our pre-commit hooks for validation of the configuration.

@runcom runcom force-pushed the ua-version branch 4 times, most recently from 9afabc4 to 962450a Compare October 24, 2025 10:36
@runcom runcom added the 1.0.0 label Oct 24, 2025
@runcom
Copy link
Member Author

runcom commented Nov 3, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a User-Agent header to outgoing client requests, which is a good feature for server-side logging and client identification. The version is injected at build time. My review has identified a few issues:

  • There is a critical error in both the Makefile and the RPM spec file in how the version is injected using linker flags. The path to the version variable is incorrect, which will cause the version to default to 'unknown'.
  • The implementation of the http.RoundTripper for adding the user agent can be made more robust to handle cases where a request might have a nil header. I've also suggested a small refactoring to improve code clarity and follow Go idioms.

Please address these points to ensure the feature works correctly and robustly.

@runcom runcom removed the 1.0.0 label Nov 7, 2025
@runcom runcom added this to the 1.0.0 milestone Nov 7, 2025
Signed-off-by: Antonio Murdaca <[email protected]>
@runcom runcom force-pushed the ua-version branch 5 times, most recently from 1adac1d to 88dea61 Compare November 8, 2025 20:30
@runcom runcom merged commit 21cb545 into fido-device-onboard:main Nov 10, 2025
20 checks passed
@runcom runcom deleted the ua-version branch November 10, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants