Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SVD Instability #17

Merged
merged 13 commits into from
Dec 12, 2024
Merged

Fix SVD Instability #17

merged 13 commits into from
Dec 12, 2024

Conversation

kuppulur
Copy link
Contributor

@kuppulur kuppulur commented Dec 2, 2024 •
edited
Loading

Fixed SVD instable tests, by using absolute values instead of actual values when testing

@kuppulur
Update ci.yml
10d281c 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur kuppulur added the WIP label Dec 2, 2024
kuppulur added 10 commits December 2, 2024 16:03
@kuppulur
Update test_transformer_base.py
7f1d0a5 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur
Update ci.yml
78e5a77 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur
Update test_transformer_base.py
0ff582f 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur
Update test_base.py
e5158a5 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur
Update test_base.py
0e1f988 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur
Fixing SVD instability
e47a088 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur
Update test_svd.py
1565a97 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur
Fix SVD sign instability
7de9ff0 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur
Update test_svd.py
acb6e58 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur
Update test_transformer_base.py
b8b7689 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur kuppulur removed the WIP label Dec 5, 2024
@kuppulur kuppulur requested a review from skadio December 5, 2024 02:09
@kuppulur
Update _version.py
2683769 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur kuppulur changed the title Update ci.yml Fix SVD Instability Dec 5, 2024
@kuppulur
Update CHANGELOG.txt
51a2f90 
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur kuppulur requested a review from takojunior December 9, 2024 14:30
takojunior
takojunior approved these changes Dec 12, 2024
View reviewed changes
Copy link

@takojunior takojunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @kuppulur

@takojunior
Copy link

We might also need to update docs?

@kuppulur
Copy link
Contributor Author

We might also need to update docs?

Since there is no change in the code, we ignore the documentation. Thanks.

@kuppulur kuppulur closed this Dec 12, 2024
@kuppulur kuppulur reopened this Dec 12, 2024
@kuppulur kuppulur merged commit 35ca015 into master Dec 12, 2024
10 checks passed
@kuppulur kuppulur deleted the test_fix_ci branch December 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takojunior takojunior takojunior approved these changes

@skadio skadio Awaiting requested review from skadio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuppulur @takojunior