Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch out separate and pivot_longer functions for separate_longer_delim #17

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Oct 23, 2024

Per description in issue #16, simplified the analysis code to only call separate_longer_delim in place of calling both separate and pivot_longer where in future analyses the number of columns used for separate may be inaccurate, making this the better method

@kweav kweav changed the base branch from main to currentToReturning October 23, 2024 15:37
Copy link
Contributor

github-actions bot commented Oct 23, 2024

⚠️ broken url errors ⚠️
There are broken url errors that need to be addressed.
Click here ➡️ for broken url errors!
Add errors that aren't errors to the resources/ignore-urls.txt file of this repo.
If you are having troubles see this guide
Comment updated at 2024-10-23-15:38:39 with changes from dc120b3

Copy link
Contributor

github-actions bot commented Oct 23, 2024

No spelling errors! 🎉
Comment updated at 2024-10-23-15:38:39 with changes from dc120b3

Copy link
Contributor

👀 Quick preview of website here *
🔬 Comprehensive download of the website here

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-10-23 with changes from the latest commit dc120b3

@kweav kweav requested a review from avahoffman October 23, 2024 15:47
@kweav
Copy link
Contributor Author

kweav commented Oct 23, 2024

Compared the graphs in the preview with the current website graphs and I don't see differences

Copy link
Contributor

@avahoffman avahoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change! All the data frames looked right when I ran them.

@kweav kweav merged commit 20931c9 into currentToReturning Nov 8, 2024
@kweav kweav deleted the betterfxn branch November 8, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants