Filter for arithmetic operations laminas#28

Signed-off-by: Flávio Gomes da Silva Lisboa <[email protected]>
fgsl · Dec 2, 2021 · a0f1c53 · a0f1c53
1 parent 15298c7
commit a0f1c53
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/FourOperations.php b/src/FourOperations.php
@@ -24,7 +24,7 @@ public function __construct(array $options)
         if (!isset($options['operation']) || (!in_array($options['operation'],$operations))){
             throw new InvalidArgumentException(sprintf(
                 '%s expects argument operation string with one of theses values: add, sub, mul or div; received "%s"',
-                __METHOD__, $options['operation']));
+                __METHOD__, (float) $options['operation']));
         }
         if (!isset($options['value'])){
             throw new InvalidArgumentException(sprintf(
@@ -36,7 +36,8 @@ public function __construct(array $options)
 
     public function filter($value)
     {
-        $operand = $this->options['value'];
+        $value = (float) $value;
+        $operand = (float) $this->options['value'];
         switch ($this->options['operation']){
             case self::ADD:
                 return ($value + $operand);

diff --git a/test/FourOperationsTest.php b/test/FourOperationsTest.php
@@ -6,7 +6,7 @@
 
 class FourOperationsTest extends TestCase
 {
-    public function testOperations()
+    public function testOperations(): void
     {
         $filter = new FourOperations(['operation'=>'add','value'=>4]);
         $this->assertEquals(9, $filter->filter(5));