Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch: show username as default for character name #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

switch: show username as default for character name #6

wants to merge 2 commits into from

Conversation

terabyte25
Copy link

No description provided.

@fgsfdsfgs
Copy link
Owner

What if someone's username is "global". Maybe we should make getUsername return "" if it couldn't be obtained and just check it in the path functions.

@terabyte25
Copy link
Author

terabyte25 commented Jun 8, 2019

What if someone's username is "global".

You could argue the same for any other default username.

@fgsfdsfgs
Copy link
Owner

That's true, which is why I'm offering to return an empty string instead.
Saves can still go in global, since that's not much of a problem.

@terabyte25
Copy link
Author

terabyte25 commented Jun 8, 2019

Sounds good to me then, I'll revert the last commit in this PR if you push those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants