add der md_eval_22 #43
Conversation
ValueError: 'editdistance/bycython.pyx' doesn't match any files
meeteval/der/md_eval.py
Outdated
| ) | ||
|
|
||
|
|
||
| def md_eval_22( |
There was a problem hiding this comment.
Can you split this into a Python function that takes RTTM objects and the cli function that takes file paths?
For WERs, the cli functions are defined in __main__.py.
There was a problem hiding this comment.
Conclusion after offline discussion:
It is possible to split the md_eval_22 function, but the code either gets ugly or differs from the WER code.
So we made this function private and for now, md_eval_22 has only a CLI interface in meeteval and no python interface.
| '--log-level', help='Log level', default='WARNING', | ||
| choices=['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL', 'SILENT'] | ||
| ) | ||
| class CLI: |
There was a problem hiding this comment.
Does it make sense to move this class somewhere else and import it in all __main__.py files? It seems weird that the DER CLI script imports the WER CLI script. meeteval.cli?
Same applies to the other functions that are imported in the DER CLI.
There was a problem hiding this comment.
While the CLI class can be used for WER and DER, it is mainly designed for WER.
Since we don't know, how future interfaces look like, I thought, we use here the concept that is used in kaldi:
Define the function where it is used and import it, where it also works.
But I could also move the code to cli.py
- make md_eval_22 python function private - remove intermediate dict - change RTTM default
No description provided.