-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CUDOS merge #402
Merged
Merged
feat: CUDOS merge #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reworked delegations to support moving - Added move delegations command - Added move balance+delegations to config - Added option to move community pool balance to separate account ## Proposed Changes _[describe the changes here...]_ ## Linked Issues _[if applicable, add links to issues resolved by this PR]_ ## Types of changes _What type of change does this pull request make (put an `x` in the boxes that apply)?_ - [ ] Bug fix (non-breaking change that fixes an issue). - [ ] New feature added (non-breaking change that adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to stop working as expected). - [ ] Documentation update. - [ ] Something else (e.g., tests, scripts, example, deployment, infrastructure). ## Checklist _Put an `x` in the boxes that apply:_ - [ ] I have read the [CONTRIBUTING](https://github.com/fetchai/fetchd/blob/main/CONTRIBUTING.md) guide - [ ] Checks and tests pass locally ### If applicable - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that code coverage does not decrease - [ ] I have added/updated the documentation ## Further comments _[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]_
…t/cudos_merger_staking
## Proposed Changes _[describe the changes here...]_ ## Linked Issues _[if applicable, add links to issues resolved by this PR]_ ## Types of changes _What type of change does this pull request make (put an `x` in the boxes that apply)?_ - [ ] Bug fix (non-breaking change that fixes an issue). - [ ] New feature added (non-breaking change that adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to stop working as expected). - [ ] Documentation update. - [ ] Something else (e.g., tests, scripts, example, deployment, infrastructure). ## Checklist _Put an `x` in the boxes that apply:_ - [ ] I have read the [CONTRIBUTING](https://github.com/fetchai/fetchd/blob/main/CONTRIBUTING.md) guide - [ ] Checks and tests pass locally ### If applicable - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that code coverage does not decrease - [ ] I have added/updated the documentation ## Further comments _[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]_ --------- Co-authored-by: Peter Bukva <[email protected]>
* fix * Better fix
* Changes * Info command * Refactor * Rewards withdrawal refactor * Removed unwanted changes * Removed unwanted comments and strings changes
pbukva
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
[describe the changes here...]
Linked Issues
[if applicable, add links to issues resolved by this PR]
Types of changes
What type of change does this pull request make (put an
x
in the boxes that apply)?Checklist
Put an
x
in the boxes that apply:If applicable
Further comments
[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]